alamb commented on code in PR #11528:
URL: https://github.com/apache/arrow-rs/pull/11528#discussion_r4275586034
##########
arrow-array/src/arithmetic.rs:
##########
@@ -296,7 +336,26 @@ native_type_op!(u8);
native_type_op!(u16);
native_type_op!(u32);
native_type_op!(u64);
-native_type_op!(i256, i256::ZERO, i256::ONE);
+native_type_op!(
+ i256,
+ i256::ZERO,
+ i256::ONE,
+ i256::MIN,
+ i256::MAX,
+ #[inline]
+ fn div_rem_checked(self, rhs: Self) -> Result<(Self, Self), ArrowError> {
Review Comment:
it took me a while to understand that this is the key part -- being able to
override this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
