adriangb commented on code in PR #11459:
URL: https://github.com/apache/arrow-rs/pull/11459#discussion_r4277631872
##########
parquet/src/util/push_buffers.rs:
##########
@@ -66,9 +71,18 @@ pub struct PushBuffers {
/// when no earlier buffer can reach the requested range, so it checks one
/// or two buffers, not all of them. See [`Self::find`].
max_len: u64,
+ /// The number of ranges in `ranges` with the length `max_len`. `max_len`
+ /// can decrease only when this count goes to zero. Thus, a release does
+ /// not scan all ranges to update `max_len` while other ranges of that
+ /// length remain.
+ max_len_count: usize,
/// The sum of the lengths of `ranges`, kept up to date so that
/// [`Self::buffered_bytes`] does not scan all ranges.
buffered_bytes: u64,
+ /// The number of empty ranges in `ranges`. [`Self::push_range`] accepts
Review Comment:
https://github.com/apache/arrow-rs/pull/11569
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
