Arawoof06 commented on PR #50523: URL: https://github.com/apache/arrow/pull/50523#issuecomment-6186040313
You're right, and the issue wording is off. With a 24-byte key `RoundUpToPowerOf2(data_len, 24)` never lands below data_len. 24 isn't a power of two so the mask isn't clean, but it still rounds to >= data_len for every length I checked. The shortfall is against the ciphertext length instead: data_len=8 rounds to 8 while the ciphertext is 16, and data_len=32 rounds to 32 while the ciphertext is 48. So it comes up short of the needed output, not below data_len. The real cause either way is the missing padding block, which is what the fix sizes in. Rebased onto main and force-pushed, so fresh CI is running. Ready for your review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
