sinbad-io opened a new pull request, #879:
URL: https://github.com/apache/arrow-rs-object-store/pull/879

   ### Which issue does this PR close?
   
   Closes #878.
   
   ### Rationale for this change
   
   The URL resolver cannot pass a custom HTTP connector to the provider 
builders it already selects. Callers must duplicate provider dispatch to use 
those connectors.
   
   ### What changes are included in this PR?
   
   - Add `parse_url_opts_with_http_connector` behind `cloud-base`.
   - Keep one provider dispatch for the existing and new entry points.
   - Pass the connector through the existing cloud and HTTP builders.
   - Forward `HttpConnector` through `Arc<T>`.
   - Test provider aliases, configuration, decoded paths, local and memory 
stores, and feature errors through the public API.
   
   On a Linux gate VM, default, no-default and cloud-only library builds pass. 
The two public API tests pass with each provider base alone, all bases 
together, and bundled providers. All four existing parser tests pass with 
bundled providers. Clippy passes for all targets with the AWS, Azure, GCS and 
HTTP features and warnings denied. Removing the connector from the shared 
builder path makes the provider test fail. Restoring it makes both public API 
tests pass.
   
   The tests use an injected HTTP service and need no live cloud credentials. 
The first feature-isolated attempt used the library unit-test target. Unrelated 
upstream tests in that target assume bundled providers and reqwest, so that 
target did not compile. The focused checks now use an integration target 
through the public API. The full test suite, WASM and other target platforms 
are not covered. No performance result is claimed.
   
   ### Are there any user-facing changes?
   
   The new resolver accepts `Option<Arc<dyn HttpConnector>>`. `None` keeps the 
default connector. Local and memory stores ignore it. The existing API and its 
behavior remain unchanged. No dependency is added.
   
   AI assistance: an AI coding assistant wrote the code, tests and this draft 
text. The owner reviewed and approved the submitted text.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to