CurtHagenlocher commented on PR #4911: URL: https://github.com/apache/arrow-adbc/pull/4911#issuecomment-6207704636
Copilot's review summary noted that `UnsupportedOptions` didn't cover the database setters or the statement's typed getters and setters. Fixed in d62b56da6. It now checks the typed getters (`NotFound`) and the byte setter (`NotImplemented`) on the database, and every typed getter and setter on the statement. DuckDB 1.5.6 accepts unknown string, integer and double options on an open database without reporting an error, so those three database setters aren't checked; a comment in the test says so. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
