Dricmoy opened a new pull request, #53949: URL: https://github.com/apache/arrow/pull/53949
### Rationale for this change `FileKeyWrapper` applies default KMS instance ID and URL values to its stored connection configuration, but it passed the original unmodified configuration to `GetKmsClient`. As a result, KMS client factories could receive empty values while the key material contained the defaults. ### What changes are included in this PR? - Pass the defaulted `kms_connection_config_` member to `GetKmsClient`. - Update the key-rotation test expectations to verify that empty KMS instance ID and URL values are replaced with defaults. ### Are these changes tested? Yes. The full `parquet-encryption-key-management-test` binary passes (24 tests), including both affected key-rotation cases. C++ formatting and lint hooks also pass. ### Are there any user-facing changes? KMS client factories now receive the documented default instance ID and URL when callers leave those fields empty, matching the existing read-path behavior. There are no public API or breaking changes. Closes #51351. ### Was AI used for this PR? In accordance with the AI generation guidelines, AI was used to inspect the relevant code paths, prepare the one-line implementation change, update the existing tests, and draft this description. The focused regression tests and the complete encryption key-management test binary were run locally. **PR code and description written by:** - [ ] Human - [x] AI **Reviewed before submission by:** - [ ] Human - [x] AI - [ ] Not reviewed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
