dmitry-chirkov-dremio commented on PR #53160: URL: https://github.com/apache/arrow/pull/53160#issuecomment-6222353440
Could we add a focused Google Benchmark case in `cpp/src/arrow/compute/kernels/scalar_string_benchmark.cc` and share before/after results? The existing helper calls `CallFunction` afresh each iteration, which recreates kernel state. To measure this optimization, please initialize one FunctionExecutor or bind one expression, then reuse it across multiple batches. I'd suggest comparing: - One batch versus many batches, keeping the total input size fixed. - A simple and a more expensive regex, plain substring matching, and LIKE's fast path versus regex fallback. - Total execution including initialization, plus steady-state execution after the first batch. A separate benchmark commit would make this easy to reproduce against both revisions. I'd prefer retaining a small representative benchmark for future regression tracking but I'm not sure about general policies of "bloating" the benchmarks. p.s. please benchmark the version after fixing concurrent initialization (see my other comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
