mbutrovich opened a new pull request, #11626: URL: https://github.com/apache/arrow-rs/pull/11626
# Which issue does this PR close? - Closes #11591 # Rationale for this change atoi 3.1.1 fixes pacman82/atoi-rs#54, which caused the bug in #11591. This is a regression in 60.0.0. #10219 bumped atoi from 2.0.0 to 3.1.0, and 59.3.1 still uses atoi 2.0.0. The integer parser in `arrow-cast/src/parse.rs` is otherwise unchanged between 59.3.1 and `main`, and the new tests pass on 59.3.1. This makes the fix a candidate for a 60.x backport. # What changes are included in this PR? The minimum atoi version in `arrow-cast` is now 3.1.1. # Are these changes tested? Yes. `test_parse_integer_bounds` in `arrow-cast/src/parse.rs` parses each integer type's bounds, one past each bound, and the all-nines values on either side of each bound, with and without leading whitespace. `test_cast_string_to_integral_overflow` in `arrow-cast/src/cast/mod.rs` now includes `"-40000"` cast to `Int16`. Both tests fail with atoi 3.1.0. # Are there any significant user-facing changes? No. ## AI Disclosure I wrote this PR with help from Claude but understand and support the core approach, implementation, and test coverage. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
