Jefffrey commented on code in PR #11636:
URL: https://github.com/apache/arrow-rs/pull/11636#discussion_r4301767502
##########
arrow-data/src/transform/fixed_size_list.rs:
##########
@@ -25,9 +25,11 @@ pub(super) fn build_extend(array: &ArrayData) -> Extend<'_> {
DataType::FixedSizeList(_, i) => *i as usize,
_ => unreachable!(),
};
+ let offset = array.offset();
Box::new(
move |mutable: &mut _MutableArrayData, index: usize, start: usize,
len: usize| {
+ let start = start + offset;
Review Comment:
perhaps this should be a checked addition to guard overflows
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
