Jefffrey commented on code in PR #11611:
URL: https://github.com/apache/arrow-rs/pull/11611#discussion_r4301901040
##########
arrow-arith/src/numeric.rs:
##########
@@ -2625,6 +2625,18 @@ mod tests {
<$type>::add_year_months_opt($date_fn(MIN_VALID_DATE),
-1).is_none(),
"add_year_months: overflow neg days"
);
+
+ // Negating i32::MIN months overflows i32: subtract must return
+ // None (reported as a Date arithmetic overflow by the kernels)
+ // instead of panicking in debug builds
+ assert!(
Review Comment:
these tests seem like theyd be more suited to be alongside types.rs, where
the functions being tested are defined
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
