Jefffrey commented on code in PR #11650:
URL: https://github.com/apache/arrow-rs/pull/11650#discussion_r4305583121
##########
arrow-arith/src/aggregate.rs:
##########
@@ -578,18 +579,20 @@ pub fn sum_array<T: ArrowNumericType, A:
ArrayAccessor<Item = T::Native>>(
return None;
}
+ let mut has_non_null_value = false;
Review Comment:
instead of this new variable, we could use
[`logical_null_count`](https://docs.rs/arrow/latest/arrow/array/trait.Array.html#method.logical_null_count)
above for the all null case check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
