pratikdeoke opened a new pull request, #54457:
URL: https://github.com/apache/arrow/pull/54457

   ### Rationale for this change
   When building Arrow via CMake's FetchContent on versions older than 3.30,
   the variable `arrow_SOURCE_DIR` (lowercase) gets overridden by FetchContent
   because `project(arrow)` sets it as a cache variable while FetchContent sets
   a normal variable with higher precedence. This causes Arrow to fail finding
   `thirdparty/versions.txt`.
   
   ### What changes are included in this PR?
   Replace `arrow_SOURCE_DIR` with `ARROW_SOURCE_DIR` in
   `cpp/cmake_modules/ThirdpartyToolchain.cmake` so that Arrow does not rely
   on the lowercase variable that conflicts with FetchContent on older CMake.
   
   ### Are these changes tested?
   The fix was verified via the workaround patch applied in
   apache/iceberg-cpp#1029, which applies the same change and confirmed it
   resolves the issue on CMake 3.28.3.
   
   Fixes: #53995


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to