pearu opened a new pull request, #54656:
URL: https://github.com/apache/arrow/pull/54656

   ### Rationale for this change
   
   On Windows, the vendored musl `strptime` does not handle `%a`, `%A`, `%b`, 
`%B`, `%h`, `%c`, `%p`, `%r`, `%x` and `%X`, because they need `nl_langinfo()`, 
which is not available there.
   
   ### What changes are included in this PR?
   
   A C-locale replacement for `nl_langinfo()`, restricted to the items the 
vendored `strptime` uses. Defining `ARROW_TEST_FALLBACK_LANGINFO` compiles the 
replacement on other platforms as well, for manual testing.
   
   ### Are these changes tested?
   
   Yes, `TimestampParser.StrptimeLocaleDirectives` covers each of these 
directives. On Windows it exercises the vendored `strptime`; elsewhere it runs 
against the system `strptime`.
   
   ### Are there any user-facing changes?
   
   On Windows, `strptime` formats with these directives now parse.
   
   ### AI usage disclosure
   
   Developed with AI assistance (Claude Code): the fix, the test and this 
description were AI-generated under my direction and reviewed line by line by 
me. I own and can debug these changes. No copyrighted material is included.
   
   * GitHub Issue: #54641
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to