alamb commented on code in PR #11727:
URL: https://github.com/apache/arrow-rs/pull/11727#discussion_r4317933034
##########
.github/workflows/rust.yml:
##########
@@ -119,14 +119,6 @@ jobs:
- name: Install cargo-msrv (if needed)
# cargo-msrv binary may be cached by the cargo cache step in
setup-builder, and cargo install will error if it is already installed
run: if which cargo-msrv ; then echo "using existing cargo-msrv
binary" ; else cargo install cargo-msrv --locked ; fi
- - name: Downgrade workspace dependencies
Review Comment:
This PR checks in Cargo.lock instead
##########
arrow-arith/Cargo.toml:
##########
@@ -19,7 +19,6 @@
name = "arrow-arith"
version = { workspace = true }
description = "Arrow arithmetic kernels"
-homepage = { workspace = true }
repository = { workspace = true }
Review Comment:
Needed to fix errors like
https://github.com/apache/arrow-rs/actions/runs/39238804526/job/118014357492?pr=11365
```shell
Run cargo +nightly doc --document-private-items --no-deps --workspace
--all-features
warning: `package.homepage` is redundant with `package.repository`
--> parquet-variant/Cargo.toml:23:12
|
23 | homepage = { workspace = true }
| ^^^^^^^^^^^^^^^^^^^^
24 | repository = { workspace = true }
| --------------------
|
```
##########
arrow-integration-test/data/integration.json:
##########
@@ -319,6 +319,89 @@
"children": []
}
]
+ },
Review Comment:
From
- https://github.com/apache/arrow-rs/pull/9888
##########
arrow-avro/src/reader/mod.rs:
##########
@@ -34,15 +34,15 @@
//!
//! This module exposes three layers of the API surface, from highest to
lowest-level:
//!
-//! * [`ReaderBuilder`](crate::reader::ReaderBuilder): configures how Avro is
read (batch size, strict union handling,
+//! * [`ReaderBuilder`]: configures how Avro is read (batch size, strict union
handling,
Review Comment:
Fixes
https://github.com/apache/arrow-rs/actions/runs/39238804526/job/118014357492?pr=11365
```
error: redundant explicit link target
|
= note: when a link's destination is not specified,
the label is used to resolve intra-doc links
= note: `-D rustdoc::redundant-explicit-links` implied by `-D warnings`
= help: to override `-D warnings` add
`#[allow(rustdoc::redundant_explicit_links)]`
error: redundant explicit link target
|
= note: when a link's destination is not specified,
the label is used to resolve intra-doc links
```
##########
arrow-schema/src/datatype_parse.rs:
##########
@@ -1435,40 +1435,40 @@ mod test {
// too large for i32
(
"FixedSizeBinary(4000000000), ",
- "Error converting 4000000000 into i32 for FixedSizeBinary: out
of range integral type conversion attempted",
+ "Error converting 4000000000 into i32 for FixedSizeBinary:",
Review Comment:
backport of
- https://github.com/apache/arrow-rs/pull/10433
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
