mbutrovich commented on code in PR #11710:
URL: https://github.com/apache/arrow-rs/pull/11710#discussion_r4339294842
##########
arrow-buffer/src/buffer/run.rs:
##########
@@ -109,8 +109,12 @@ where
///
/// # Panics
///
+ /// Panics if the [`RunArray` invariants] are not satisfied:
+ ///
/// - `run_ends` does not contain strictly increasing values greater than
zero
/// - The last value of `run_ends` is less than `logical_offset +
logical_length`
Review Comment:
> - The last value of `run_ends` is less than `logical_offset +
logical_length`
Should this item say "when `logical_length` is not 0"? The
[code](https://github.com/apache/arrow-rs/blob/322f43c2bfeb7b98ec4264c2026e3fc683486127/arrow-buffer/src/buffer/run.rs#L124)
only asserts it under `if logical_length != 0`, and the new `# offset and len`
section on `RunArray` already says `len > 0`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
