alamb commented on a change in pull request #404:
URL: https://github.com/apache/arrow-datafusion/pull/404#discussion_r640937844
##########
File path: datafusion/src/physical_plan/mod.rs
##########
@@ -509,6 +514,76 @@ pub trait Accumulator: Send + Sync + Debug {
fn evaluate(&self) -> Result<ScalarValue>;
}
+/// Source represents where the data comes from.
+enum Source<R = Box<dyn Read + Send + Sync>> {
Review comment:
I think that would improve the code, but I also think it would be fine
to move the code into its own module as a follow on PR, depending on @heymind
's preference
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
