tustvold commented on code in PR #872:
URL:
https://github.com/apache/arrow-rs-object-store/pull/872#discussion_r4345173878
##########
src/parse.rs:
##########
@@ -122,7 +122,8 @@ impl ObjectStoreScheme {
{
(Self::MicrosoftAzure, strip_bucket().unwrap_or_default())
} else if host.ends_with("amazonaws.com") {
- match host.starts_with("s3") {
+ // Virtual-hosted URLs have a bucket name before the S3
service label.
+ match host.starts_with("s3") && !host.contains(".s3") {
Review Comment:
Would a more accurate fix be
```suggestion
match host.starts_with("s3.") {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
