taepper opened a new pull request, #54925: URL: https://github.com/apache/arrow/pull/54925
### Rationale for this change This fixes #54924. An extension array would not round-trip correctly through ArraySpans as a test demonstrates. ### What changes are included in this PR? This fixes the `HasVariadicBuffers` implementation to correctly handle extension types. A test demonstrating the fix is also included. The fix follows the implementation of `ArraySpan::SetMembers`, where the same additional case for extension types is included ### Are these changes tested? Yes. By the existing test suite plus an additional test. ### Are there any user-facing changes? None other than the bug fix. ### Was AI used for this PR? In accordance to the [AI generation guidelines](https://arrow.apache.org/docs/dev/developers/overview.html#ai-generated-code), please disclose below whether and how AI was used in this PR. **PR code and description written by:** - [X] Human - [ ] AI **Reviewed before submission by:** - [X] Human - [X] AI - [ ] Not reviewed An LLM suggested the second fix for ``` if (type_id == Type::STRING_VIEW || type_id == Type::BINARY_VIEW) { ``` in `ArraySpan::SetMembers`, which does look correct to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
