timmyb32r opened a new pull request, #11826: URL: https://github.com/apache/arrow-rs/pull/11826
# Which issue does this PR close? None — standalone bug fix. # Rationale for this change DataType::contains checks whether self is a superset of other. For Union types, the check iterated over self's variants instead of other's, reversing the containment relationship. # What changes are included in this PR? Check that every variant in other has a matching type ID and compatible field in self. # Are these changes tested? Added regression tests for both sparse and dense unions covering subset containment, empty unions, reordered fields, nullability, and incompatible type IDs, field types, and union modes. # Are there any significant user-facing changes? <!-- Significant user-facing changes include: - Breaking public API change - Significant change to existing functionality (e.g. function returns something different) These need to be explicitly called out to ensure we have proper documentation if required and to ensure we follow proper semantic versioning. DO NOT restate the changes of this PR; if a bug was fixed and already explained above, we don't need this to be restated as a user-facing change. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
