JonSnow1807 opened a new pull request, #993:
URL: https://github.com/apache/arrow-nanoarrow/pull/993

   ### Summary
   
   `TestingJSONComparison::CompareFieldBase` was comparing metadata on the 
parent field but not checking metadata on its children.
   
   That meant two nested schemas could compare as equal even when their child 
fields had different metadata.
   
   This change makes the comparison recurse into child fields, including 
dictionary children, and reuse the existing metadata comparison logic.
   
   It still treats absent and empty metadata as equivalent, and the existing 
order-insensitive metadata comparison behavior is preserved.
   
   ### Testing
   
   Added a gtest covering metadata differences in list, map, and dictionary 
children.
   
   All 291 CTest tests pass.
   
   This is separate from #972, which deals with dictionary value metadata.
   
   Fixes #973.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to