alamb commented on code in PR #11788: URL: https://github.com/apache/arrow-rs/pull/11788#discussion_r4352825366
########## CONTRIBUTING.md: ########## @@ -73,6 +73,20 @@ When possible, we recommend splitting your contributions into multiple smaller focused PRs rather than large PRs, because they are more likely to be reviewed quickly and are easier to understand and review. +### Pull Requests from Forks + +To reduce load on ASF's shared runners, pull requests from forks to `main` +run tests in the fork and lightweight checks upstream. + +1. Open the **Actions** tab in your fork and enable workflows before pushing. +2. Sync your fork and rebase your branch onto upstream `main` to include the + current CI workflows. +3. Push your branch, or manually run `CI` from your fork's **Actions** tab. + View results and rerun failed jobs there; the PR's `CI (fork)` check may lag. + +Fork results are informational. The merge queue tests the proposed merge with Review Comment: Maybe we could phrase this like "When your PR is approved and added to the merge queue, the final CI checks are run using the ASF runners" ########## CONTRIBUTING.md: ########## @@ -73,6 +73,20 @@ When possible, we recommend splitting your contributions into multiple smaller focused PRs rather than large PRs, because they are more likely to be reviewed quickly and are easier to understand and review. +### Pull Requests from Forks + +To reduce load on ASF's shared runners, pull requests from forks to `main` +run tests in the fork and lightweight checks upstream. Review Comment: I suggest we make the implications clear here ```suggestion run the CPU intensive tests on your fork (using the forks github runners). To enable actions in your fork: ``` ########## .github/workflows/README.md: ########## @@ -17,7 +17,24 @@ under the License. --> -CI runs a subset of checks on pull requests, selected by the changed files. +CI runs lightweight checks upstream for fork pull requests to `main`. Fork Review Comment: I think this documentation should go 1. In the contributor guide so it is clear what is happening 2. The description of what each job does (e.g. ``fork_ci_status.yml` mirrors fork results in an informational `CI (fork)` check,`) I think should be comments in the scripts themselves along with the commands to test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
