zeroshade opened a new pull request, #1411:
URL: https://github.com/apache/arrow-go/pull/1411

   ### Rationale for this change
   
   The Lint, RC and Test workflows use
   
   ```yaml
   concurrency:
     group: ${{ github.repository }}-${{ github.head_ref || github.sha }}-${{ 
github.workflow }}
     cancel-in-progress: true
   ```
   
   `github.head_ref` is only the source branch name, without the fork owner. 
Two pull requests from different forks that happen to use the same branch name 
share a concurrency group, so each new run cancels the other PR's in-progress 
run.
   
   This happened with #1406 and #1407, both from branches named 
`fix/parquet-hidden-column-error`: #1407's Test run cancelled a re-run of 
#1406's Test job partway through (run 39903724796, attempt 3: `Test=cancelled`, 
"The operation was canceled").
   
   ### What changes are included in this PR?
   
   Key the group by `github.event.pull_request.number` instead of 
`github.head_ref` in `lint.yml`, `rc.yml` and `test.yml`:
   
   ```yaml
     group: ${{ github.repository }}-${{ github.event.pull_request.number || 
github.sha }}-${{ github.workflow }}
   ```
   
   - `pull_request` events: one group per PR, so a new push to a PR still 
cancels that PR's older run, but different PRs no longer interfere.
   - `push` events: `pull_request.number` is empty, so the group falls back to 
`github.sha`, unchanged from today.
   
   ### Are these changes tested?
   
   `actionlint` accepts all three workflows (its only reports are pre-existing 
shellcheck quoting notes in `run:` scripts). This PR's own CI runs exercise the 
new groups.
   
   ### Are there any user-facing changes?
   
   No.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to