Jefffrey opened a new issue, #11884: URL: https://github.com/apache/arrow-rs/issues/11884
[`arrow-array/src/delta.rs`](https://github.com/apache/arrow-rs/blob/9d7f294ca6bfa3591616059d11a3c15464a21f58/arrow-array/src/delta.rs) carries an MIT license because it originally copied code from [`chronoutil`](https://github.com/olliemath/chronoutil). See the PR which introduced this: - https://github.com/apache/arrow-rs/pull/2031 However, in the current state, it has been changed quite drastically, to the point that only the test code is what remains from the original (even then its modified a little). See the original [`delta.rs`](https://github.com/olliemath/chronoutil/blob/7107a49ffb1f21d0efeb9be5850e07c9715a9817/src/delta.rs) from chronoutil. Because of this MIT license, we need to add it to our notices: https://github.com/apache/arrow-rs/blob/9d7f294ca6bfa3591616059d11a3c15464a21f58/LICENSE.txt#L206-L209 https://github.com/apache/arrow-rs/blob/9d7f294ca6bfa3591616059d11a3c15464a21f58/NOTICE.txt#L7-L9 https://github.com/apache/arrow-rs/blob/9d7f294ca6bfa3591616059d11a3c15464a21f58/arrow-array/LICENSE-MIT - Adding MIT license file to arrow-array Not to mention `delta.rs` itself having a MIT header (which is what I noticed when reviewing #11497) ## Action Is this still technically under MIT license, considering the code was changed significantly? Can we remove these licenses? > 4. Minor modifications/additions to third-party source files should typically be licensed under the same terms as the rest of the third-party source for convenience. > 5. The project's PMC should deal with major modifications/additions to third-party source files on a case-by-case basis. - https://www.apache.org/legal/src-headers.html This seems to suggest maybe its not technically under MIT anymore and should be Apache license? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
