Phoenix500526 commented on code in PR #11497:
URL: https://github.com/apache/arrow-rs/pull/11497#discussion_r4369510541
##########
licenserc.toml:
##########
@@ -16,28 +14,34 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-#
-
-RAT_VERSION=0.13
-
-# download apache rat
-if [ ! -f apache-rat-${RAT_VERSION}.jar ]; then
- curl -s
https://repo1.maven.org/maven2/org/apache/rat/apache-rat/${RAT_VERSION}/apache-rat-${RAT_VERSION}.jar
> apache-rat-${RAT_VERSION}.jar
-fi
-RAT="java -jar apache-rat-${RAT_VERSION}.jar -x "
+[header]
+builtin = "Apache-2.0-ASF"
-RELEASE_DIR=$(cd "$(dirname "$BASH_SOURCE")"; pwd)
+[files]
+includes = ["*.rs", "*.py", "*.md", "*.toml", "*.sh"]
+excludes = [
Review Comment:
One exclusion I would appreciate your view on is
`arrow-flight/examples/data/gen_certs.sh`.
It cites a [Rust forum
post](https://users.rust-lang.org/t/use-tokio-tungstenite-with-rustls-instead-of-native-tls-for-secure-websockets/90130/2).
The [forum terms](https://users.rust-lang.org/tos) license contributions after
July 17, 2020 under MIT/Apache-2.0. However, the script's distinctive
`/C=FI/CN=vahid` argument and the same source comment also appear in [this
Stack Overflow answer](https://stackoverflow.com/a/76136847), suggesting that
it may have been adapted via that answer. The forum post itself does not
contain that argument, so the current source comment alone does not establish
the full provenance.
Given the [ASF guidance on copying Stack Overflow
code](https://www.apache.org/legal/resolved.html), would you prefer that we
clarify permission or replace the script in a follow-up, or address this in the
migration PR? I have left this script's existing header state unchanged pending
that decision.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
