raulcd commented on code in PR #55167: URL: https://github.com/apache/arrow/pull/55167#discussion_r4374876559
########## cpp/subprojects/packagefiles/google-brotli/LICENSE.build: ########## @@ -0,0 +1,19 @@ +Copyright (c) 2021 The Meson development team Review Comment: None of this chanegs under `cpp/subprojects/google-brotli` seem necessary to me. ########## cpp/thirdparty/versions.txt: ########## @@ -58,8 +58,8 @@ ARROW_AZURE_SDK_BUILD_VERSION=azure-identity_1.9.0 ARROW_AZURE_SDK_BUILD_SHA256_CHECKSUM=97065bfc971ac8df450853ce805f820f52b59457bd7556510186a1569502e4a1 ARROW_BOOST_BUILD_VERSION=1.92.0 ARROW_BOOST_BUILD_SHA256_CHECKSUM=f51707c27359a0df0cac1beada86de31bb5eed5e8285592dadec384df99c2984 -ARROW_BROTLI_BUILD_VERSION=v1.0.9 -ARROW_BROTLI_BUILD_SHA256_CHECKSUM=f9e8d81d0405ba66d181529af42a3354f838c939095ff99930da6aa9cdf6fe46 +ARROW_BROTLI_BUILD_VERSION=v1.0.10 Review Comment: Is there any reason we don't bump to something newer here? Given that we are bumping our bundle dependency we could try and bump to latest (1.2.1) unless other dependencies have other constraints. ########## ci/vcpkg/ports.patch: ########## @@ -1,3 +1,28 @@ +diff --git a/ports/brotli/portfile.cmake b/ports/brotli/portfile.cmake +index e55c69c3d1..7d7cb1d67e 100644 +--- a/ports/brotli/portfile.cmake Review Comment: This is not necessary. We can bump the vcpkg version used on `.env` and avoid this patch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
