raulcd commented on code in PR #54905:
URL: https://github.com/apache/arrow/pull/54905#discussion_r4375285990
##########
cpp/src/arrow/CMakeLists.txt:
##########
@@ -992,8 +969,31 @@ if(ARROW_FILESYSTEM)
PROPERTIES SKIP_UNITY_BUILD_INCLUSION ON)
endif()
if(ARROW_GCS)
- list(APPEND ARROW_FILESYSTEM_SRCS filesystem/gcsfs.cc
filesystem/gcsfs_internal.cc)
- set_source_files_properties(filesystem/gcsfs.cc
filesystem/gcsfs_internal.cc
+ set(ARROW_GCS_STATIC_INSTALL_INTERFACE_LIBS Arrow::arrow_static)
+ if(google_cloud_cpp_storage_SOURCE STREQUAL "SYSTEM")
+ list(APPEND ARROW_GCS_STATIC_INSTALL_INTERFACE_LIBS
google-cloud-cpp::storage)
+ elseif(google_cloud_cpp_storage_SOURCE STREQUAL "BUNDLED")
+ list(APPEND ARROW_GCS_STATIC_INSTALL_INTERFACE_LIBS CURL::libcurl)
+ if(absl_SOURCE STREQUAL "SYSTEM")
+ # Bundled google-cloud-cpp with system Abseil needs these for static
consumers.
+ list(APPEND
+ ARROW_GCS_STATIC_INSTALL_INTERFACE_LIBS
+ absl::base
+ absl::cord
+ absl::crc32c
+ absl::memory
+ absl::optional
+ absl::span
+ absl::str_format
+ absl::strings
+ absl::time
+ absl::variant)
+ endif()
+ endif()
+ set(ARROW_GCS_LIB_SRCS filesystem/gcsfs_module.cc filesystem/gcsfs.cc
+ filesystem/gcsfs_internal.cc)
Review Comment:
This seems relevant but there's no tests on this area to validate gcs that's
why CI did not fail. I wonder whether we should add a test that exercises this
so this is caught on CI. I am also wondering what is the approach the Ruby
bindings want, link the new `libarrow_gcs.so` so the filesystem is registered
or use the `LoadFileSystemFactories`, @kou what do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
