princejain756 commented on PR #11904: URL: https://github.com/apache/arrow-rs/pull/11904#issuecomment-6415085415
In 5132371 I hoisted `match remap.as_deref()` out of the per-row closure in `row_lengths` (matching `encode_column`). Previously `remap.as_ref()` was checked on every row inside `row_lengths`, which showed up on the un-compacted `string_dictionary_low_cardinality` benchmark in the GKE run (`21.4us -> 24.9us`); with the check hoisted outside the loop, the `None` branch is identical to `main`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
