ShivanshhhG commented on PR #54574: URL: https://github.com/apache/arrow/pull/54574#issuecomment-6415714375
Hi @dmitry-chirkov-dremio, Thank you for the review! I have updated the PR to address both comments: 1. **FromArrays call argument order:** Fixed the parameter order across all tests to supply `MemoryPool*` as the 3rd argument and the null validity bitmap buffer as the 4th argument. 2. **ListView / LargeListView support:** Updated `ValidateLengths` using `if constexpr (is_list_view_type<SrcType>::value)` to read lengths from the sizes buffer (`buffers[2]`) and verify contiguous offsets rather than reading past the offsets buffer (`offsets[length]`). Added regression tests for all-null `ListView` and `LargeListView` inputs with empty children casting to `FixedSizeList`. All tests and linters are updated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
