hutiefang76 commented on code in PR #1391:
URL: https://github.com/apache/arrow-java/pull/1391#discussion_r4378028482
##########
flight/flight-sql-jdbc-core/src/main/java/org/apache/arrow/driver/jdbc/ArrowDatabaseMetadata.java:
##########
@@ -1001,6 +1026,192 @@ public ResultSet getPrimaryKeys(final String catalog,
final String schema, final
connection, flightInfoPrimaryKeys, transformer);
}
+ @Override
+ public ResultSet getTypeInfo() throws SQLException {
+ final ArrowFlightConnection connection = getConnection();
+ final BufferAllocator allocator = connection.getBufferAllocator();
+
+ final FlightInfo flightInfoTypeInfo;
+ try {
+ flightInfoTypeInfo = connection.getClientHandler().getXdbcTypeInfo();
+ } catch (final FlightRuntimeException e) {
+ throw new SQLException("Failed to retrieve type info.", e);
Review Comment:
Implemented in 284386dc: both `getFlightInfo` and stream initialization now
fall back to `super.getTypeInfo()` for `UNIMPLEMENTED`. Other Flight failures
still become `SQLException`.
Two real Flight-server regressions check the empty 18-column JDBC schema, no
rows and allocator buffers returning to baseline. With identical final test
bytes, the reviewed production revision failed those two cases; the fix passes
all 11 focused tests. Local affected-reactor verification also passed: Flight
SQL 97 tests; JDBC Core 1255 records, including 44 existing skips; packaged
driver validation 2 integration tests. Upstream CI results for this follow-up
remain pending.
<sub>AI-assisted patch and reply using DeepSeek and Codex; the tests above
were executed locally.</sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
