Nishuuzz commented on PR #55162: URL: https://github.com/apache/arrow/pull/55162#issuecomment-6423882671
Done — switched this over to removing `--with-all`. Rebased on main and force-pushed, so it is now just the option and its parameter gone, plus the `Integration.rst` example rewritten to enable each implementation explicitly, since that page was the only thing still pointing at the flag. The description is rewritten to match. No test, since Click rejects an unknown option on its own and a test asserting a flag's absence would only have to be deleted if it ever came back. I did check that `--with-all` now exits 2 with `No such option '--with-all'`, that the untouched paths still behave (nothing enabled with no flags, only C++ with `--with-cpp=1`), that the newly documented command enables all eight implementations, and that the archery suite matches pristine main. One aside, not part of this: `_set_default()` just above the command is unused, and has been since it was added in 2019 — it is visible in the first hunk. Happy to drop it here if you would like it gone, or leave it alone. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
