mzabaluev commented on code in PR #11872:
URL: https://github.com/apache/arrow-rs/pull/11872#discussion_r4381240605
##########
arrow-select/src/filter.rs:
##########
@@ -1245,6 +1255,105 @@ fn filter_sparse_union(
})
}
+/// Sets the bits of `bytes` in the non-empty range `start..end`
+fn set_bit_range(bytes: &mut [u8], start: usize, end: usize) {
+ debug_assert!(start < end);
+ let (start_byte, end_byte) = (start / 8, end / 8);
Review Comment:
Yes, it's been optimized that way forever, so the more descriptive code is
better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
