jorgecarleitao commented on pull request #382: URL: https://github.com/apache/arrow-rs/pull/382#issuecomment-850961132
Thanks @ritchie46 . My small concerns with this PR: 1. We are introducing yet another builder API for something relatively easy to accomplish with an extra method 2. `preallocate_buffers` assumes that "preallocate" means allocate the maximum possible capacity, which IMO is not really pre-allocating, is just being very conservative and allocating the maximum. 3. The API is rather limited to the `concatenate` case. I left some ideas as a comment on the issue -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
