ConnorQi01 opened a new pull request, #55280:
URL: https://github.com/apache/arrow/pull/55280

   ### Rationale for this change
   
   `ARROW_BUILD_STATIC` indicates library availability, not selected test
   linkage. When shared-linked Windows tests inherit static API definitions
   through `arrow_compute_testing`, `arrow-dlpack-test` fails with duplicate
   `arrow::Status` definitions.
   
   ### What changes are included in this PR?
   
   Select the helper's Windows static API definitions using
   `ARROW_TEST_LINKAGE STREQUAL "static"` instead of `ARROW_BUILD_STATIC`.
   No library variant is disabled and no test is removed.
   
   ### Are these changes tested?
   
   The real DLPack target at `d228ba5` reproduces the original LNK2005/LNK1169.
   After the change, rebuilding in the same directory succeeds and all
   39 DLPack tests from 10 suites pass.
   
   The extracted exact target section additionally passes shared-tests with both
   variants, static-tests, and shared-only linkage controls. The patch also
   applies to current main `4a6ebc06`. The full Arrow suite was not run.
   
   ### Are there any user-facing changes?
   
   Only the Windows test helper's compile definitions change. No public API or
   library-build option changes.
   
   ### Was AI used for this PR?
   
   Copilot assisted with diagnosis, the conditional change, the targeted
   validation workflow, and this description. No internal compiler inputs or
   private pipeline logs are included.
   
   **PR code and description written by:**
   
   - [ ] Human
   - [x] AI
   
   **Reviewed before submission by:**
   
   - [ ] Human
   - [x] AI
   - [ ] Not reviewed
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to