andishgar commented on PR #51325: URL: https://github.com/apache/arrow/pull/51325#issuecomment-6447851236
@pitrou, I implemented my [approach](https://github.com/apache/arrow/pull/51325#issuecomment-5775514193) [here](https://github.com/user-attachments/files/34030625/365163.patch)and your [approach](https://github.com/apache/arrow/pull/51325#issuecomment-5775113327) [here](https://github.com/user-attachments/files/34030623/0f144c.patch). Please consider both patches as prototypes; they pass all existing tests. As far as I can tell, your suggested approach does not actually avoid any scalar allocations. In fact, I couldn't find any scalar being created in the first place. It also seems that `arrow::ArrayRangeEqual` would need to be largely reimplemented. What do you think would be the better direction: adding a new option to `EqualOptions`, or implementing custom array equality as in your approach? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
