etseidl opened a new pull request, #11975: URL: https://github.com/apache/arrow-rs/pull/11975
# Which issue does this PR close? - Closes #11974 - Follow up to #11953 # Rationale for this change See issue. Reduce code duplication and add more validation to Bloom filter parsing. # What changes are included in this PR? - Share metadata validation, header/bitset layout parsing, checked file-range calculation, and exact-respo nse validation between synchronous and asynchronous reads. - Delegate the synchronous Arrow builder's Bloom filter reads to `Sbbf::read_from_column_chunk`. - Apply the same header and bitset validation to `Sbbf::from_bytes`. - Remove redundant parsing wrappers and share the sync/async recording-reader test fixtures. # Are these changes tested? Yes, new tests are added # Are there any significant user-facing changes? No public APIs are changed, but some invalid inputs that were previously accepted will now return an error. Synchronous reads and `Sbbf::from_bytes` now reject zero-sized or non-block-aligned serialized bitsets and inconsistent declared lengths (matching asynchronous behavior introduced in #11953). # AI disclosure Implementation and regression tests were prepared with coding-agent assistance, but were reviewed by me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
