HuaHuaY commented on code in PR #51286:
URL: https://github.com/apache/arrow/pull/51286#discussion_r4411013541
##########
cpp/src/arrow/csv/options.h:
##########
@@ -65,6 +65,8 @@ struct ARROW_EXPORT ParseOptions {
bool pad_short_rows = false;
/// Whether rows with more columns than expected should ignore the extra
columns.
bool ignore_extra_columns = false;
+ /// Multi-character field delimiter. If non-empty, overrides `delimiter`.
+ std::string delimiter_string;
Review Comment:
I have addressed all comments except for this. I let my LLM agent work on
deprecating the `delimiter` field. It involves quite a few changes (affecting
over 20 files and totaling more than 200 lines of code, and spanning Python, R,
and Ruby). Should I include these changes in this PR, or open a separate PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
