jhorstmann commented on code in PR #12003:
URL: https://github.com/apache/arrow-rs/pull/12003#discussion_r4432791696
##########
parquet/src/column/writer/mod.rs:
##########
@@ -2259,7 +2260,7 @@ mod tests {
let metadata = r.metadata;
assert_eq!(
metadata.encodings().collect::<Vec<_>>(),
- vec![Encoding::PLAIN, Encoding::RLE]
Review Comment:
While adding these tests I realized that we still write an empty dictionary
page for all-null data. The data page in that case has encoding RLE_DICTIONARY,
so it could be expected that it is preceded by a dictionary page.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
