fboudra commented on PR #51372:
URL: https://github.com/apache/arrow/pull/51372#issuecomment-6549616569
> BTW, it would help with reviewing if you left your own further code
changes as separate commits, instead of combining it within the rebased commits
from the other PR (now it is hard to see which review comments from #50409 you
have addressed)
ack
> > Also included, found while going through the files: a shadowed variable
in AppendUTF32, a missing extension path in the MonthDayNano conversion, and
the MonthDayNano docstring.
>
> What is this exactly about?
All three are on lines the abi3 rewrite touches anyway. The shadowing rename
is hygiene. MonthDayNano is required: PyStructSequence_NewType is the only
structseq constructor abi3 allows, and heap types need the fully-qualified
name, so the repr becomes pyarrow.lib.MonthDayNano(...). The docstring feeds
the __init__ help text in heap-type form. Repr change is user-visible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
