EmilyMatt commented on code in PR #11982:
URL: https://github.com/apache/arrow-rs/pull/11982#discussion_r4435489370
##########
parquet/src/arrow/arrow_writer/byte_array.rs:
##########
@@ -85,26 +113,9 @@ macro_rules! downcast_op {
DataType::BinaryView => {
$op($array.as_any().downcast_ref::<BinaryViewArray>().unwrap()$(, $arg)*)
}
- DataType::Dictionary(key, value) => match value.as_ref() {
- DataType::Utf8 => downcast_dict_op!(key, StringArray, $array,
$op$(, $arg)*),
- DataType::LargeUtf8 => {
- downcast_dict_op!(key, LargeStringArray, $array, $op$(,
$arg)*)
- }
- DataType::Utf8View => {
- downcast_dict_op!(key, StringViewArray, $array, $op$(,
$arg)*)
- }
- DataType::Binary => downcast_dict_op!(key, BinaryArray,
$array, $op$(, $arg)*),
- DataType::LargeBinary => {
- downcast_dict_op!(key, LargeBinaryArray, $array, $op$(,
$arg)*)
- }
- DataType::BinaryView => {
- downcast_dict_op!(key, BinaryViewArray, $array, $op$(,
$arg)*)
- }
- DataType::FixedSizeBinary(_) => {
- downcast_dict_op!(key, FixedSizeBinaryArray, $array,
$op$(, $arg)*)
- }
- d => unreachable!("cannot downcast {} dictionary value to byte
array", d),
- },
+ DataType::Dictionary(key, value) => {
+ downcast_dict_values_op!(key, value, $array, $op$(, $arg)*)
+ }
Review Comment:
It isn't just moved, it is now called from a different place. the
alternative is having a fully copy of it^^
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
