HippoBaro commented on PR #11741: URL: https://github.com/apache/arrow-rs/pull/11741#issuecomment-6585822810
@etseidl I missed the review cycle for this one. Overall, I'm very happy with the changes, except for the addition of the inline-more feature. My concern isn't so much with inlining itself, but with the fact that Cargo unifies features across the dependency graph. By enabling hashbrown/inline-more here, we're effectively forcing it on for every other crate using the same version of hashbrown, even if those crates explicitly opted out. Inlining is a tradeoff: it can improve runtime performance (though not always, in fact I found out about this while investigating regressions while rebasing #11273), but at the cost of increased compilation time and potentially larger binaries. I think that tradeoff should ultimately be left to the consumer rather than imposed by a library. Wdyt? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
