pitrou commented on code in PR #55169:
URL: https://github.com/apache/arrow/pull/55169#discussion_r4447224997
##########
cpp/src/arrow/compute/kernels/vector_swizzle.cc:
##########
@@ -87,6 +126,8 @@ struct InversePermutationImpl {
template <typename Type>
enable_if_t<is_integer_type<Type>::value, Status> Visit(const Type&
output_type) {
+ // Keep output execution specialized so the loops remain inlineable.
Sharing
+ // output signedness can cause aggressive outlining and regress throughput.
Review Comment:
I'm not sure what the comment alludes to ("Sharing output signedness")?
##########
cpp/src/arrow/compute/kernels/vector_swizzle_test.cc:
##########
Review Comment:
This test is superseded by `IndexBounds` below, no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
