tadeja commented on PR #55264: URL: https://github.com/apache/arrow/pull/55264#issuecomment-6604643806
A note while I'm still reviewing `array.pyi`. With 3ddf085: `__lib/array.pyi` - removed duplicating `NullableCollection`, added optional import ignores (like in `types.pyi` already), and corrected `__dlpack__` signature `tests/test_array.py` a new regression test for DLPack ( Optional import ignores not yet added for _stubs_typing.pyi, __lib/tensor.pyi or __lib/table.pyi ) <details><summary>Type checking without NumPy, pandas, SciPy</summary> <p> uv run --isolated --no-project --with mypy==2.4.0 --with pyright==1.1.414 --with ty==0.0.92 bash -c 'mypy --no-incremental; pyright; ty check' **Resolved**: pyarrow-stubs/pyarrow/__lib/array.pyi:29: error: Cannot find implementation or library stub for module named "numpy" [import-not-found] pyarrow-stubs/pyarrow/__lib/array.pyi:29: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports pyarrow-stubs/pyarrow/__lib/array.pyi:30: error: Library stubs not installed for "pandas" [import-untyped] pyarrow-stubs/pyarrow/__lib/array.pyi:30: note: Hint: "python3 -m pip install pandas-stubs" pyarrow-stubs/pyarrow/__lib/array.pyi:30: note: (or run "mypy --install-types" to install all missing stub packages) **Remaining**: pyarrow-stubs/pyarrow/_stubs_typing.pyi:30: error: Cannot find implementation or library stub for module named "numpy" [import-not-found] pyarrow-stubs/pyarrow/_stubs_typing.pyi:32: error: Cannot find implementation or library stub for module named "numpy.typing" [import-not-found] pyarrow-stubs/pyarrow/__lib/tensor.pyi:26: error: Cannot find implementation or library stub for module named "numpy" [import-not-found] pyarrow-stubs/pyarrow/__lib/tensor.pyi:30: error: Library stubs not installed for "scipy.sparse" [import-untyped] pyarrow-stubs/pyarrow/__lib/tensor.pyi:30: note: Hint: "python3 -m pip install scipy-stubs" pyarrow-stubs/pyarrow/__lib/table.pyi:32: error: Cannot find implementation or library stub for module named "numpy" [import-not-found] pyarrow-stubs/pyarrow/__lib/table.pyi:33: error: Library stubs not installed for "pandas" [import-untyped] pyarrow-stubs/pyarrow/__lib/table.pyi:33: note: Hint: "python3 -m pip install pandas-stubs" pyarrow-stubs/pyarrow/__lib/table.pyi:33: note: (or run "mypy --install-types" to install all missing stub packages) pyarrow-stubs/pyarrow/__lib/table.pyi:35: error: Cannot find implementation or library stub for module named "numpy.typing" [import-not-found] pyarrow-stubs/pyarrow/__lib/table.pyi:35: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports Found 7 errors in 3 files (checked 22 source files) /Users/tadeja/Documents/arrow/python/pyarrow-stubs/pyarrow/__lib/table.pyi /Users/tadeja/Documents/arrow/python/pyarrow-stubs/pyarrow/__lib/table.pyi:32:8 - error: Import "numpy" could not be resolved (reportMissingImports) /Users/tadeja/Documents/arrow/python/pyarrow-stubs/pyarrow/__lib/table.pyi:33:8 - error: Import "pandas" could not be resolved (reportMissingImports) /Users/tadeja/Documents/arrow/python/pyarrow-stubs/pyarrow/__lib/table.pyi:35:6 - error: Import "numpy.typing" could not be resolved (reportMissingImports) /Users/tadeja/Documents/arrow/python/pyarrow-stubs/pyarrow/__lib/tensor.pyi /Users/tadeja/Documents/arrow/python/pyarrow-stubs/pyarrow/__lib/tensor.pyi:26:8 - error: Import "numpy" could not be resolved (reportMissingImports) /Users/tadeja/Documents/arrow/python/pyarrow-stubs/pyarrow/__lib/tensor.pyi:30:6 - error: Import "scipy.sparse" could not be resolved (reportMissingImports) /Users/tadeja/Documents/arrow/python/pyarrow-stubs/pyarrow/_stubs_typing.pyi /Users/tadeja/Documents/arrow/python/pyarrow-stubs/pyarrow/_stubs_typing.pyi:30:8 - error: Import "numpy" could not be resolved (reportMissingImports) /Users/tadeja/Documents/arrow/python/pyarrow-stubs/pyarrow/_stubs_typing.pyi:32:6 - error: Import "numpy.typing" could not be resolved (reportMissingImports) 7 errors, 0 warnings, 0 informations All checks passed! </p> </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
