kszucs commented on a change in pull request #469:
URL: https://github.com/apache/arrow-datafusion/pull/469#discussion_r643229440



##########
File path: python/src/dataframe.rs
##########
@@ -93,6 +93,18 @@ impl DataFrame {
         })
     }
 
+    /// Sort by specified sorting expressions
+    fn sort(&self, exprs: Vec<expression::Expression>) -> PyResult<Self> {
+        let exprs = exprs.into_iter().map(|e| e.expr);
+        let builder = LogicalPlanBuilder::from(&self.plan);

Review comment:
       I think we could share `ExecutionContext.state` between the python 
binding and `DataFrameImpl` at some point, though it is not urgent. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to