omkar-334 opened a new pull request, #55386:
URL: https://github.com/apache/arrow/pull/55386

   ### Rationale for this change
   `DeltaByteArrayDecoderImpl` keeps a `last_value_in_previous_page_` member 
that is written when a page is fully consumed, but it is never read. It was 
meant to work around PARQUET-246 (files written with a bug where the previous 
value is carried across pages), but that workaround was never implemented, so 
the member is dead state. 
   
   Fixes #55385
   
   ### What changes are included in this PR?
   Removes `last_value_in_previous_page_`, its initializer, the assignment 
after a page is consumed, and the TODO in `SetData` that referred to it. 
`last_value_` is still cleared at the start of each page, so decoding is 
unchanged.
   
   ### Are these changes tested?
   Yes, by the existing delta byte array decoder tests. No new tests are needed 
since there is no behaviour change.
   
   ### Are there any user-facing changes?
   No.
   
   ### Was AI used for this PR?
   **PR code and description written by:**
   
   - [x] Human
   - [x] AI
   
   **Reviewed before submission by:**
   - [x] Human
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to