zeroshade commented on code in PR #1458:
URL: https://github.com/apache/arrow-go/pull/1458#discussion_r4470199818
##########
arrow/compute/scalar_bool.go:
##########
@@ -136,5 +136,5 @@ func RegisterScalarBoolean(reg FunctionRegistry) {
makeFunction(reg, "or_kleene", 2,
kernels.SimpleBinary[kernels.KleeneOrOpKernel],
orKleeneDoc, exec.NullComputedPrealloc)
makeFunction(reg, "not", 1, kernels.NotExecKernel, notDoc,
- exec.NullComputedNoPrealloc)
+ exec.NullIntersection)
Review Comment:
For the release notes: with preallocation, chunked input now comes back as a
single contiguous chunk instead of matching the input's chunks (on main, a
2-chunk input gave 2 output chunks; here it gives 1). That's consistent with
the other boolean kernels and you mention it in the description, but callers
that pair output chunks with input chunks would see a change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
