hcrosse commented on PR #1444: URL: https://github.com/apache/arrow-go/pull/1444#issuecomment-6637102025
Thanks. I added both: - The `DictionaryBuilder` docs now say that consecutive `NewArray` and `NewDictionaryArray` calls can return arrays that share one dictionary, that releasing those arrays alone does not free it, and that the shared dictionary must be treated as immutable. They also say to release the builder before checking that its allocator is empty. - `BenchmarkReadDictionaryColumn` in `parquet/pqarrow` reads a dictionary-encoded string column with `SetReadDict` at several dictionary sizes and batch sizes. Its write and read helpers are separate functions, so the benchmark for https://github.com/apache/arrow-go/pull/1447 can reuse them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
