amoeba opened a new pull request, #4993: URL: https://github.com/apache/arrow-adbc/pull/4993
Updates the Rust driver manager manifest search code to return errors and error details that match what C++ and C# do. Each test covers a case and the table below describes what changed at high level: | Test | Before | After | |---|---|---| | `test_load_from_name_missing_or_invalid_driver` | `Internal` | `NotFound`, with the path in the error | | `test_manifest_wrong_arch` | `InvalidArguments` | `NotFound`, with more detail in the error | | `test_load_dynamic_missing_driver` | `Internal` | `NotFound`, with the path in the error | | `test_empty_driver_name` | `NotFound` | `InvalidArguments`, with a clear error message | | `test_load_from_name_invalid_manifest_by_path_or_name` | `InvalidArguments` by path, `NotFound` by name | `InvalidArguments` either way, and the error includes the manifest path | | `test_relative_driver_path_disallowed` | `InvalidArguments` | `InvalidArguments`, and the error now includes the path | Continuation of: - https://github.com/apache/arrow-adbc/pull/4972 - https://github.com/apache/arrow-adbc/pull/4973 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
