hcrosse commented on PR #1464: URL: https://github.com/apache/arrow-go/pull/1464#issuecomment-6640766692
@zeroshade Thanks for running so many value types. I added the doc note on `NewNullDictScalar`. I kept `TestNullDictionaryScalar` on `Value.Dict` because `MakeArrayFromScalar` returns `MakeArrayOfNull` for a null scalar before reading the dictionary, so it already works on main for those types at lengths of 1 or more and would not catch this bug. I couldn't reproduce a `Concatenate` panic on main from these scalars. A null scalar takes the `MakeArrayOfNull` path, and only a valid dictionary scalar reaches `Concatenate`. I'd appreciate the snippet if you have one. The crash I reproduced is the nil dereference in `FillFromScalar` during `is_null`, covered by `TestIsNullDictionaryScalar`. Since your review, I fixed two problems Copilot flagged that the new dictionary caused: leaks where callers use `NewDatum`, and a panic for nested null value types such as `struct<null>`, fixed in `MakeArrayOfNull` itself. The updated description has the details. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
