zeroshade commented on PR #1439:
URL: https://github.com/apache/arrow-go/pull/1439#issuecomment-6634847304
Thanks for the quick turnaround. All four points are addressed. Locally with
pyarrow 26.0.1, `PARQUET_TEST_REQUIRE_PYARROW=1 go test -race -run Pyarrow
./parquet/` passes; with the flag set and no pyarrow it fails as intended;
without the flag it skips. I also confirmed the new footer-magic check fails if
the file is written with an encrypted footer. The `cd "${source_dir}"` fix
matches the `go.mod file not found` failure in the previous run. I've approved
the workflow and will approve once the CGO Python jobs are green.
A few small nits, none blocking:
- `requirePyarrow`: `require := os.Getenv(...)` hides the testify `require`
package inside that function. Maybe rename it to `mustHavePyarrow`.
- `writeInteropEncryptedFile`: pyarrow reads the file fine without
`WithFooterKeyMetadata("kf")`, so either drop it or change the "mirroring what
pyarrow needs" comment.
- The `interopPython` doc comment says the same thing twice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
