mapleFU commented on code in PR #55323:
URL: https://github.com/apache/arrow/pull/55323#discussion_r4468997914
##########
cpp/src/parquet/level_comparison.cc:
##########
@@ -45,6 +40,8 @@ struct GreaterThanDynamicFunction {
static constexpr auto targets() {
return std::array{
ARROW_DISPATCH_TARGET_NONE(&standard::GreaterThanBitmapImpl) //
+ ARROW_DISPATCH_TARGET_NEON(&GreaterThanBitmapNeon) //
+ ARROW_DISPATCH_TARGET_SSE4_2(&GreaterThanBitmapSse42) //
ARROW_DISPATCH_TARGET_AVX2(&GreaterThanBitmapAvx2) //
Review Comment:
SSE2/AVX2 is faster with https://github.com/xtensor-stack/xsimd/issues/1443
in my EPYC Zen4, but without this, it wouldn't faster or slower. I can just add
Neon version, and leave it here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
